[GitHub] cloudstack pull request: Fix another findbugs high priority warnin...

2015-06-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/364 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix another findbugs high priority warnin...

2015-06-08 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/364#issuecomment-109890819 LGTM. asfbot looks like known issue with java version in a unrelated module. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cloudstack pull request: Fix another findbugs high priority warnin...

2015-06-07 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/364 Fix another findbugs high priority warning JuniperSrxResource.java:2617, ES_COMPARING_STRINGS_WITH_EQ, Priority: High Comparison of String objects using == or != in com.cloud.network.reso