Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1092
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-159894668
@DaanHoogland, @remibergsma, can this be merged in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-159643377
The code LGTM now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-159642930
@rafaelweingartner, implemented the test cases as suggested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-159632142
@nvlivens,
I would suggest you to write two test cases instead of one.
One test case to test the encode method and another to test the decode
meth
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-159629890
@rafaelweingartner, I've added a test for those methods
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-159123334
The code seems ok, but what about a PR description and test cases for those
encode and decode methods that were created?
---
If your project is set up fo
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158791293
LGTM, all integration tests pass.
 and newStringUtf8() would no
longer be used.
2. With this new code, we won't any longer be only dependent on UTF-8, but
rat
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158385988
@nlivens looks good, but I have some questions still
1. So why wouldn't you encorporate this in your getBytesUtf8() and
newStringUtf8() methods?
2. How
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158381857
@DaanHoogland, how about the following piece of code then? In this case we
are using the getPrefferedCharset()
```java
public static String encodePa
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158376719
@nlivens @fmaximus I have to ask you to reconsider. if
getPreffferedCharset() does not return UTF8 it is because it is not supported
on the platform. how do yo
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158375131
@DaanHoogland, @fmaximus was right about the encoding. I rewrote that part
so we're always using the same encoding :)
---
If your project is set up for it, you can
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158328407
[1092.test_network.results.txt](https://github.com/apache/cloudstack/files/39874/1092.test_network.results.txt)
[1092.test_vpc.results.txt](https://github.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158136481
@fmaximus preffered charset will be utf8 if it is available in the virtual
machine (afaik always) otherwise it is the platform default
---
If your project is
Github user fmaximus commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158100736
I think we should use StringUtils.getUtf8Bytes() instead, as we are using
StringUtils.newStringUtf8(Base64.decodeBase64(cmsUserPassBase64)) on the other
side (Nuag
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158033304
thanks @nlivens lgtm but will run regression tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1092#issuecomment-158026133
@DaanHoogland, this PR contains the fixes for the build-master-slowbuild
---
If your project is set up for it, you can reply to this email and have your
reply appea
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1092
Fix NuageVsp errors for build-master-slowbuild
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack master
Alternatively you
20 matches
Mail list logo
