[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread swill
Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1543#discussion_r63215625 --- Diff: test/integration/component/test_acl_listvolume.py --- @@ -357,9 +357,9 @@ def tearDownClass(cls): cls.apiclient = super(TestVolumeLis

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread swill
Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1543#discussion_r63215404 --- Diff: test/integration/component/test_acl_listvolume.py --- @@ -357,9 +357,9 @@ def tearDownClass(cls): cls.apiclient = super(TestVolumeLis

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-219095904 Thanks for the effort stabilizing Jenkins and Travis the last few days. This has been super helpful as we get close to the freeze. Very much appreciated. Most of t

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-219095201 Thanks @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1543 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-219071379 Most of these things are fixes to Jenkins and travis issues, so those jobs being green is good validation of the fixes. The main functionality change has been valida

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-218987023 I've also fixed a integration/component test that has failed on Travis several time for various PRs due to cleanup order (tearDown issue): ``` Marvin

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-218980870 code LGTM. trusting @kiwiflyer I will probably test later but am a bit stuck today. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-218978811 LGTM based on code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-12 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1543 Fix Nio/CPU issue and CI failures - Reverts ea2286 that introduced a wakeup on each connection loop run. - In SSL handshake code removes delegated tasks to be run in separate threads.

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-12 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1543 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is