[GitHub] cloudstack pull request: Fix/citrix resource base packages

2015-05-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/317 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix/citrix resource base packages

2015-05-27 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/317#issuecomment-105940965 Hi @xenserverarmy , I'm just checking what is going on that the mirror doesn't get updated, then will apply the change you suggested. Cheers

[GitHub] cloudstack pull request: Fix/citrix resource base packages

2015-05-27 Thread xenserverarmy
Github user xenserverarmy commented on the pull request: https://github.com/apache/cloudstack/pull/317#issuecomment-105936788 One suggestion. In the future we may have pure Xen support, so if possible we should ensure all naming for XenServer is "XenServer" and not Xen. So please ch

[GitHub] cloudstack pull request: Fix/citrix resource base packages

2015-05-27 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/317#issuecomment-105935874 I merged this PR, but the mirror on github doesn't get it. Just did a new clone from Apache git to get a fresh copy and I see the commit there:

[GitHub] cloudstack pull request: Fix/citrix resource base packages

2015-05-27 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/317#issuecomment-105897981 All tests are passing. Don't know the reason for the failure on travis. Test system VM start ... === TestName: test_01_sys_vm_start | Status : SUCCES

[GitHub] cloudstack pull request: Fix/citrix resource base packages

2015-05-27 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/317#issuecomment-105893558 It's a bit weird, I executed the same test agains my XenServer62: Test system VM start ... === TestName: test_01_sys_vm_start | Status : SUCCESS ===

[GitHub] cloudstack pull request: Fix/citrix resource base packages

2015-05-27 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/317 Fix/citrix resource base packages Hi @DaanHoogland and @bhaisaab I have fixed the packaging under the test directory. All the tests classes had the package declaration