[GitHub] cloudstack pull request: FIX: Ovm3 physical network traffic labels...

2015-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/964 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: FIX: Ovm3 physical network traffic labels...

2015-10-25 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/964#issuecomment-150979025 @remibergsma @snuf I've run the following tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=false

[GitHub] cloudstack pull request: FIX: Ovm3 physical network traffic labels...

2015-10-23 Thread snuf
Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/964#issuecomment-150653911 @remibergsma thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: FIX: Ovm3 physical network traffic labels...

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/964#issuecomment-150632854 LGTM, based on a set of tests that I run on this branch (results below). Also looked at the labels and they look fine. Thanks @snuf ! ``` nosetests -

[GitHub] cloudstack pull request: FIX: Ovm3 physical network traffic labels...

2015-10-22 Thread snuf
GitHub user snuf opened a pull request: https://github.com/apache/cloudstack/pull/964 FIX: Ovm3 physical network traffic labels to work. The labeling was broken. Only labels assigned at zone creation were used, changing labels was not working. Tested with changing a label and