Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259649
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self):
self.conf.search(sli
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259430
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def ma
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259249
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def ma
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259089
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def ma
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50252187
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self):
self.conf.
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50251936
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1346
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50251745
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50251651
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self):
self.conf.sear
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50251563
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1346#issuecomment-173187438
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50241366
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
d
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1346#issuecomment-173169424
Ping @borisroman @remibergsma
PR LGTM :+1:
* Environment
* Hardware required: TRUE
* Management Server + MySQL on CentOS 7.1
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50058474
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self):
self.conf.search(sli
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50057844
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def ma
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50057840
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def ma
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1346#issuecomment-172512058
Started the tests:
```
[root@cs1 integration]# nosetests --with-marvin
--marvin-config=/data/shared/marvin/mct-zone1-kvm1-ISOLATED.cfg -s -a
ta
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1346#issuecomment-172505604
Have started tests on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1346#issuecomment-172488515
Hi @borisroman
Thanks for the fixes! It will really make the VRs behave better! :)
I now sit next to Boris here at Schuberg Philis and was
Github user resmo commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r49976226
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def ma
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1346
Enhance VR performance
Will post integration test results soon!
Ping @wilderrodrigues @remibergsma
You can merge this pull request into a Git repository by running:
$ gi
21 matches
Mail list logo
