[GitHub] cloudstack pull request: Dhcp dns offload feature code changes

2015-05-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/315 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Dhcp dns offload feature code changes

2015-05-27 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/315#issuecomment-106197052 Looks good. i cannot judge the functionality (even after reading the FS) use case makes sense and asfbot and travis seem to agree nothing else is going to suffe

[GitHub] cloudstack pull request: Dhcp dns offload feature code changes

2015-05-27 Thread ydder
Github user ydder commented on the pull request: https://github.com/apache/cloudstack/pull/315#issuecomment-106164654 @DaanHoogland FS link is there in ticket. Please find the it below https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=53740797 --- If your project i

[GitHub] cloudstack pull request: Dhcp dns offload feature code changes

2015-05-27 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/315#issuecomment-106040557 @ydder Looks Good. Good to see you added a unit test as well. In your description of how to do a test of the overall feature I am missing what the 'config drive

[GitHub] cloudstack pull request: Dhcp dns offload feature code changes

2015-05-27 Thread ydder
GitHub user ydder opened a pull request: https://github.com/apache/cloudstack/pull/315 Dhcp dns offload feature code changes Added dhcp dns offload feature code changes in this patch. The changes added in this patch are for only xenserver. While this pull request is in review