Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/696#issuecomment-134941139
@bhaisaab Yes, willing to do so. I even think that I started to work on
this some time ago, but never finished it.
---
If your project is set up for it, you can reply
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/696
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/696#issuecomment-134936732
@insom that was for Wido since he has experience in writing bindings in
libvirt-java etc.
---
If your project is set up for it, you can reply to this email and hav
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/696#issuecomment-134932108
Not sure if @bhaisaab's comment about improvement is directed at me or
@wido. If it was at me, I'd prefer if this could be merged (as it's in the
current style and I b
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/696#issuecomment-134916799
LGTM. I second @wido. We should try to get rid of direct virsh commands,
would you like to work on improving this to use libvirt-java? (and if bindings
are lacking
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/696#issuecomment-132146849
LGTM
The resizing in general should be done using libvirt-java and not by
executing 'virsh' at all.
It could be that the Java bindings for libvirt are
GitHub user insom opened a pull request:
https://github.com/apache/cloudstack/pull/696
Default to notify only script to handle non-CLVM/QCOW cases.
This relates to
[CLOUDSTACK-8732](https://issues.apache.org/jira/browse/CLOUDSTACK-8732)
Before this commit the call to `getRe
