[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/643 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/643#issuecomment-127169469 thanks @kansal LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/643#issuecomment-126599320 Thanks @kansal , please change the commit message to point to it. For instance: CLOUDSTACK-8692: resource leak found by the internal coverity instance at

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/643#issuecomment-126583069 Cool :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/643#issuecomment-126570824 @DaanHoogland @miguelaferreira I understand you concerns. I have created the ticket for this in JIRA with ID: CLOUDSTACK-8692. Will keep this in mind while for future

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/643#issuecomment-126319900 Hi @kansal If this issue was caught by your internal Coverity scan, wouldn't it also have been cough by the public Coverity scan? Or are these confi

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/643#issuecomment-126319443 -1 on this. I cannot track any internal tracking system of another company. please if the public coverity doesn't have this make a jira ticket describve the pro

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/643#issuecomment-126301540 @DaanHoogland It was the issue that was reported by our internal coverity. The issue reported is: "noescape: Resource 'in' is not closed or saved in readObjec

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/643#discussion_r35860179 --- Diff: server/src/org/apache/cloudstack/region/RegionsApiUtil.java --- @@ -186,8 +186,12 @@ protected static UserAccount makeUserAccountAPICall(Re

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/643#issuecomment-126274712 @kansal please add the coverity number to the commit message, this way we can not track it. And while you look at it make sure you put the issue on your name to

[GitHub] cloudstack pull request: Coverity Issue: Resource Leak fixed

GitHub user kansal opened a pull request: https://github.com/apache/cloudstack/pull/643 Coverity Issue: Resource Leak fixed Resource leak fixed. Please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kansal/cloudstack Cov