Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217383124
Squashed and force pushed. Tasks remaining:
- [ ] Pass CI
- [ ] Situational testing on VPC RvR
- [ ] Some automated tests
Regarding the auto
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217290925
@kiwiflyer I have not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217290619
Has anyone tested this with VPC VRs as of yet?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217279039
That worked a treat. The suggestions made by @ustcweizhou resulted in a
very clean set of IP rules and I was able to add IPs on eth4 and eth5 without
breaking the r
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217268926
Thank you for working on fixing this. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217110131
Currently I'm investigating @ustcweizhou suggestions above. He's quite
correct about not adding the mark for eth0 and I think I've reproduced the
problem he reporte
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-216435381
@swill agree for keeping it against 4.7; but it would be great if @dsclose
can squash the changes to a single commit as all of them solve for
Cloudstack-9339 issue
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-216267768
I am also fine with these being separate commits as they are functionally
separate.
---
If your project is set up for it, you can reply to this email and have your
r
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-216267457
@rhtyd is there a reason you want him to rebase to master? We still
support 4.7, so all fixes to that branch will be forward merged to 4.8 and
master. I think this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-216229957
@dsclose rebase against master, squash changes to a single commit, thanks
tag:needlove
---
If your project is set up for it, you can reply to this email and
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1519#discussion_r61681715
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -423,22 +443,15 @@ def fw_router(self):
self.fw.append(
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1519#discussion_r61681494
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -289,51 +290,62 @@ def post_configure(self, address):
route
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1519#discussion_r61681472
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -289,51 +290,62 @@ def post_configure(self, address):
route
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-215480948
@ustcweizhou How would you recommend I separate this? I can imagine
separating the issues broadly into two parts:
1. **Routing tables and iptables rules sho
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-215347296
@dsclose I think it is better to split this PR into some isolated PRs, as
the issues are isolated.
to be honest, some commits looks good to me ( as we have s
GitHub user dsclose opened a pull request:
https://github.com/apache/cloudstack/pull/1519
Cloudstack 9339: Virtual Routers don't handle Multiple Public Interfaces
This PR addresses CLOUDSTACK-9339 and may need a code review from someone
familiar with the System VM scripts. In partic
16 matches
Mail list logo
