Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/637
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126331708
So I will amend the interrupted to be level debug and then merge. next I
will create a new PR for any remaining empty catch blocks, @koushik-das.
---
If your p
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126260440
@DaanHoogland Merge this in 4.6. If possible push the log level changes in
4.6 as well.
---
If your project is set up for it, you can reply to this email and ha
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126238495
So @koushik-das Do you propose the folowing?
- merge this for 4.6
- make a critical ticket for 4.7 to asses log levels
note that I am not completely d
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126233316
Changes LGTM, since we are creating a separate bug for correctly handling
log levels.
@DaanHoogland I am not saying to remove the interrupted exceptions, just
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126215256
@kishankavala @DaanHoogland :+1: for the Jira ticket.
After 4.6 we can come back to this and assess the messages accordingly. But
would be nice to h
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126214607
Code wise it is LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126206244
@kishankavala you actually made me think I should wait till after 4.6, on
the other hand we will have to take the pain in a release.
---
If your project is set
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126205414
@DaanHoogland
Agreed that setting appropriate log level is out of the scope for this PR.
But we should file a jira ticket to track and address it before nex
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126204154
Fair enough, @DaanHoogland
Thanks for the exaplanation. :)
LGTM :+1:
---
If your project is set up for it, you can reply to this email an
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126202911
@koushik-das, Ignoring interrupted exceptions means that you do not allow
the user or other threads to interrupt you. To me that seems serious. I did not
in any
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126200897
Hi @DaanHoogland
Nice you took time to have a look at those. It really helps sys admins to
know what is going on with ACS. However, I would rather h
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126185823
Since all these "ignore" messages are logged at INFO level, it needs to be
ensured that logs are not getting filled up too soon. Also I see lot of
instances for
13 matches
Mail list logo
