Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1479#discussion_r59486626
--- Diff: agent/src/com/cloud/agent/Agent.java ---
@@ -227,6 +227,7 @@ public void start() {
try {
_connection.start();
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1479
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-208676729
@kiwiflyer woohoo!!! thank you for all the support on this. i will merge
this in the morning with my next batch.
---
If your project is set up for it, you can repl
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-208661647
@swill - I force pushed it again and Jenkins is finally passing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-208344314
Squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-208322941
@kiwiflyer Sorry to do this to you, but would you mind squashing your
commits and doing a `push -f` again? Thanks...
---
If your project is set up for it, you can r
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207866865
For whatever reason, I can't seem to force push this. I'll try again from
my laptop this evening.
---
If your project is set up for it, you can reply to this ema
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207861224
I apologize @miguelaferreira. You are correct, I tagged the wrong handle.
It was actually @rafaelweingartner.
---
If your project is set up for it, you ca
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207838857
@kiwiflyer I can't seem to find that PR discussion you mention. Maybe you
got the wrong handle?
---
If your project is set up for it, you can reply to this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207714662
@kiwiflyer Jenkins is failing. Not sure how the error could be related to
your code changes, so can you do a `push -f` again to kick it off again.
Here is th
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207627057
Thank you @kiwiflyer. Once Jenkins finishes I will merge this since we
have the code reviews we need and there is no logical changes that need to be
tested (since @p
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207618243
@swill Squashed and force pushed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207539579
Can you squash your commits and do a `push -f` to update your branch so
this gets merged as a single commit?
This does not change anything that could fail via
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207537198
Simply added a log warning. Built it LGTM
[INFO]
[INFO] Reactor Summary:
[INFO]
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207507877
Got it @kiwiflyer. I am good with the way it is.
Simple logger change, the code LGTM.
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207504054
@GabrielBrascher The reason I placed it before is because the follow on
log message is basically informing that a reconnect attempt was going to be
attempted nex
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207501906
@kiwiflyer shouldn't the `s_logger.warn("NIO Connection Exception " + e);`
be after the info `s_logger.info("Attempted to connect")`?
---
If your proje
GitHub user kiwiflyer opened a pull request:
https://github.com/apache/cloudstack/pull/1479
Cloudstack-9285 exception log addition
After discussion with @miguelaferreira on the previous PR related to
Cloudstack-9285, we decided on adding additional exception logging for this
issue.
18 matches
Mail list logo
