Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1459
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-212541636
I think this one is ready now. I will add it to my merge queue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-212512170
@DaanHoogland I removed `@param`, `@return` and `@throws` from javadoc.
Thanks.
---
If your project is set up for it, you can reply to this email and have
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r60444764
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -206,4 +216,87 @@ public static void scpTo(String host, int port, String
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-212395104
@swill LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r60393439
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -206,4 +216,87 @@ public static void scpTo(String host, int port, String
use
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-211991515
I have one LGTM. I need one more and this PR is ready to merge. Thanks
guys...
---
If your project is set up for it, you can reply to this email and have your
repl
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-211989957
Thanks @swill!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-211936017
## CI RESULTS
### 84/85 TESTS PASSED
The test that failed is a test that commonly fails in my environment and
has been verif
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-208987688
I have tried a few times, but I also was having problems with my CI when
trying to test this. I was getting errors, but I was trying to determine if it
was my env or
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-208986832
@swill, @DaanHoogland
Have you already executed test on this one?
---
If your project is set up for it, you can reply to this email and have your
rep
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-207446285
@rafaelweingartner now I am ensuring that the "Thread.sleep()" method is
being called properly. Also I removed the method that was checking if the
session w
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-207159853
That is great.
Shouldn't you also verify if the sleep method is being used? If we remove
that (the sleep), will the code continue to work as it is now?
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-207159361
@rafaelweingartner now I am using PowerMockito to test the
"throwSshExceptionIfSshConnectionIsNull" method without the need to wait for
the "Thread.sleep(WA
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-206931826
@swill thanks for the effort. Don't worry, I can wait ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-206927968
I have run CI against this PR, but I am not going to post the results yet
because I think my test environment likely influenced the results. I think I
am trying to p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-206443694
yes, I can add that note. I will get CI run against this once I get
through my backlog a bit.
---
If your project is set up for it, you can reply to this email and
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-206415115
@swill if this is ok to you you can add an extra comment line in the merge
commit stating
```
This closes #561
```
---
If your project is set u
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-205968363
Well, if this PR gets merged, I do not know much how we can close the PR
#561. Maybe @swill or @DaanHoogland can help with that.
Now the code LG
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-205932840
@rafaelweingartner now this commit is not cherry-picked from the
commit (b9181c689e0e7b5f1e28c81d73710196dfabd0ba). When this PR be merged
(or closed),
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-205755861
Thanks @DaanHoogland, I will check on that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-205715741
the other one is persistant i'm afraid:
[1459.results.vpc_redundant.txt](https://github.com/apache/cloudstack/files/204056/1459.results.vpc_redundant.txt)
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-205684941
the first one wwas a false positive:
[1459.results.password.txt](https://github.com/apache/cloudstack/files/203940/1459.results.password.txt)
---
If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-205679998
@GabrielBrascher I ran the regression suite as defined by SBP and found two
failures. I am rerunning them individually to see if I can find out some more.
Here
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-205604082
@GabrielBrascher, since @likitha seems to have left the community, could
you take over all of the changes and just commit the changes in a way that the
di
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r58478990
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -1,209 +1,306 @@
-//
-// Licensed to the Apache Software Foundat
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-205554379
Pretty clever the way you named the test methods, I liked it.
Just another thing.
The method "throwSshExceptionIfSshConnectionIsNull" you are testin
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r58466286
--- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java ---
@@ -0,0 +1,131 @@
+//
+// Licensed to the Apache Software Foundat
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r58442984
--- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java ---
@@ -0,0 +1,131 @@
+//
+// Licensed to the Apache Software Found
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r58442410
--- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java ---
@@ -0,0 +1,131 @@
+//
+// Licensed to the Apache Software Foundat
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r58407949
--- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java ---
@@ -0,0 +1,131 @@
+//
+// Licensed to the Apache Software Found
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r58407383
--- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java ---
@@ -0,0 +1,131 @@
+//
+// Licensed to the Apache Software Found
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-205381727
@GabrielBrascher please continue as you please. the old code has been
neglected. if you want to attribute please feel free to do so in the comment
for that com
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-204571209
Correcting myself, the history from the SshHelper
(https://github.com/likitha/cloudstack/commits/CLOUDSTACK-8611/utils/src/com/cloud/utils/ssh/SshHelper.java
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-204484447
@DaanHoogland thanks for the hint, but the problem is not related to line
ending.
The problem is that there are two (2) different SshHelper classes
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-204303829
@GabrielBrascher what shows is that unchanged line are changed. This could
mean that you are using different line endings. Are you working on a windows
machine
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-204293184
Not sure why it shows as if I had changed all the SshHelper class (the
diff shows removed lines that I have not changed). I will check on that.
---
If yo
GitHub user GabrielBrascher opened a pull request:
https://github.com/apache/cloudstack/pull/1459
Cloudstack 8611 Handle SSH if server "forget" to send exit status
Continuing the work started by @likitha, I cherry-picked the
commit (b9181c689e0e7b5f1e28c81d73710196dfabd0ba) fro
38 matches
Mail list logo
