[GitHub] cloudstack pull request: Change variable "ROOK_DISK_CONTROLLER" to...

2016-03-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Change variable "ROOK_DISK_CONTROLLER" to...

2016-03-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1434#issuecomment-195096276 Merging giving LGTMs and that build passes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Change variable "ROOK_DISK_CONTROLLER" to...

2016-03-10 Thread pedro-martins
Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/1434#issuecomment-194957493 Simple change in variable name, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cloudstack pull request: Change variable "ROOK_DISK_CONTROLLER" to...

2016-03-09 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1434#issuecomment-194619387 Simple typo fix. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Change variable "ROOK_DISK_CONTROLLER" to...

2016-03-09 Thread GabrielBrascher
GitHub user GabrielBrascher opened a pull request: https://github.com/apache/cloudstack/pull/1434 Change variable "ROOK_DISK_CONTROLLER" to "ROOT_DISK_CONTROLLER" Change com.cloud.vm.VmDetailConstants variable name from "ROOK_DISK_CONTROLLER" to "ROOT_DISK_CONTROLLER". The ROOK_DISK