Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/995
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/995#issuecomment-153012986
LGTM :+1: based on the 40 tests I execute + the 71 tests @remibergsma
executed!
Cheers,
Wilder
---
If your project is set up for it, you can r
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/995#issuecomment-153010146
LGTM I agree with @wido that unit tests are desirable but I will not block
this for them. It will automatically block on regression.
---
If your project is set
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/995#issuecomment-152581144
@wilderrodrigues did you run more tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/995#issuecomment-152440604
Ping @remibergsma @karuturi @kansal
Partial test results:
* Hardware required: false
* Management Server + MySQL on CentOS 7.1
* One
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/995#issuecomment-152192762
Testing this PR now.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/995#issuecomment-152119427
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/995#issuecomment-151784319
Seems good to me, but while we are working on this. Any way we can Unit
Test this? Looking at the code it's possible.
If you could just write a test to validate
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/995
CLOUDSTACk-9002: VM deployment is successful even when dhcp entry comâ¦
â¦mand fails - Fixed
Reason: The return value of the call to accept() function in the
applyRules() function of B
