[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-26 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-222046182 Hi @ustcweizhou @DaanHoogland @remibergsma, I moved global config definitions to `ConfigKey.java` instead of `Config.java` and `schema-481to490.sql`.

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-16 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-219473209 @remibergsma, @DaanHoogland Current global support for nested virtualization is only vmware specific and done in VmwareGuru. Are you proposing to move the logic

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-16 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-219468957 @remibergsma In some private cloud environments nested virtualization is not a good fit so it is generally disabled. That's fine but we found that it would be very n

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-15 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-219270106 @nvazquez Can you use ConfigKey instead of changes on Config.java and schema-481to490.sql ? --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-14 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-219206665 KVM also has this feature and there you can enable/disable it in the agent.properties file (ant not per VM). We should try to make the code as generic as possib

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-219052329 :) no worries, just expect some review comments to this extend ;) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-13 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-219051673 Hi @DaanHoogland, unfortunately I really didn't examine it for other hypervisors. In our environment we only use VMware ESXi hypervisor, that's the main reason for

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-218977461 @nvazquez I like the functional description and will probably run through the code over the weekend but one thing struck me. A lot of this should apply equally

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-12 Thread nvazquez
GitHub user nvazquez opened a pull request: https://github.com/apache/cloudstack/pull/1542 CLOUDSTACK-9379: Support nested virtualization at VM level on VMware Hypervisor ## Introduction [JIRA TICKET](https://issues.apache.org/jira/browse/CLOUDSTACK-9379) It is des