[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-219077065 Thanks, closed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user nvazquez closed the pull request at: https://github.com/apache/cloudstack/pull/1539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-218789994 @nvazquez, @rhtyd's commit has been merged as part of his larger PR at #1502, so we can close this PR since the result of this PR has already been merged. Thanks eve

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r63026066 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-218766563 @swill @rhtyd @DaanHoogland I reordered cleanup as in [@rhtyd's commit](https://github.com/apache/cloudstack/pull/1502/commits/6135f6d98fa6b363b0468c17a8e713aeb5054

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r63012011 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r63011767 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r63011147 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r62995623 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r62994980 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r62994401 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r62967100 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-218657103 I think one way to cleanup would be to do it case by case basis for each test case manually instead of relying on the class level cleanup. Also, it's best to avoid us

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-218654451 Sorry for the delay getting to this. I think this probably works in all cases, but I suspect it will not clean up correctly always. Because this was working sometim

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-218652190 LGTM, cc @swill let's merge this first to avoid other PRs failing --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

GitHub user nvazquez opened a pull request: https://github.com/apache/cloudstack/pull/1539 CLOUDSTACK-9378: Fix for #1497 JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9378 After #1497 was merged, test_list_ids_parameter.py failed on Travis. It was noticed t