[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1528 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1528#issuecomment-218597484 I think this one is good to go... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1528#issuecomment-218247494 Hey Will, Unless the error you received indicated that the test failed due to a nonexistent method, we should be fine. I'm looking at this f

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1528#issuecomment-218245081 I reran the failing tests, which got rid of one of the errors, but the `FAIL: Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1528#issuecomment-218244511 ### CI RESULTS ``` Tests Run: 94 Skipped: 0 Failed: 3 Errors: 0 Duration: 11h 00m 30s ``` **Summary of the

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1528#issuecomment-217269826 Thanks @mike-tutkowski. I will run CI against this one just to be sure we did not break anything... --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1528#issuecomment-216970419 @swill Looks like we are good to go with this review. Thanks for the reviews @rhtyd and @DaanHoogland! --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1528#issuecomment-216448597 LGTM but let's run as much marvin tests as possible --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1528#issuecomment-216433425 LGTM based on the discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

GitHub user mike-tutkowski opened a pull request: https://github.com/apache/cloudstack/pull/1528 CLOUDSTACK-9373: Class methods over-shawdowing instance methods We have some methods in base.py that are named the same. Per my findings below, Python methods in a class should n