Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1516
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-220512874
### CI RESULTS
```
Tests Run: 84
Skipped: 0
Failed: 0
Errors: 2
Duration: 8h 36m 08s
```
**Summary of the p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-220393200
Thank you for the clean up. It looks much better now. I will rerun CI on
this...
---
If your project is set up for it, you can reply to this email and have your
re
Github user sudhansu7 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r63895181
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) un
Github user sudhansu7 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r63894357
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) un
Github user sudhansu7 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r63893826
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) un
Github user sudhansu7 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r63893791
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) un
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r63739326
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r63739140
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r63738462
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r63738053
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user sudhansu7 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r63731204
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) un
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r63722337
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r63721020
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r63720420
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user sudhansu7 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r63715139
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) un
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r63707528
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r63707401
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user sudhansu7 commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-219995275
@swill Thanks for the review. I have updated the test. Now its green.
finally.
---
If your project is set up for it, you can reply to this email and have your
r
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-219707593
@sudhansu7 there are problems with the tests added in this PR. We need to
be programming a lot more defensively. There are a LOT of places where
something like this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-219706136
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 2
Duration: 8h 54m 46s
```
**Summary of the p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-219538895
@sudhansu7 can you rebase and push to see if we can get this green before
the freeze? Thx...
---
If your project is set up for it, you can reply to this email and h
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-218962171
@sudhansu7 yeah, my bad -- I've fixed them here:
https://github.com/apache/cloudstack/pull/1543
---
If your project is set up for it, you can reply to this email and
Github user sudhansu7 commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-218960848
@rhtyd
Jenkin build is failing for cloud-util tests.
Below is the snippet. Could you please check this.
--
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-218807140
@sudhansu7 I pushed fixes to Jenkins and Travis this morning. Can you
please force push again so we can get this green. Thanks...
---
If your project is set up for
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-218366572
@sudhansu7 can you force push again to kick off Jenkins and Travis again?
Thx...
---
If your project is set up for it, you can reply to this email and have your
rep
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-217472184
Can you force push again to get the jobs to kick off again. thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-217269248
Can you do a force push to kick of Jenkins again. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user sudhansu7 commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-217105794
@rhtyd @swill
The branch has been re-based against master and also squashed multiple
commits to a single.
---
If your project is set up for it, you can repl
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-216435537
@sudhansu7 can you rebase against latest master, squash the changes to a
single commit and push -f to re-kick travis. Thanks
---
If your project is set up for it, yo
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-216305760
@DaanHoogland thanks...
@sudhansu7 can you do a force push to kick off the travis run again so we
can get this PR green. Thx...
---
If your project is set
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-216303934
LGTM, considdered it implied by the test report but here it is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-216286395
We are missing one code review on this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-216229873
@sudhansu7 rebase against master and push -f, squash changes to a single
commit, thanks
---
If your project is set up for it, you can reply to this email and have yo
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-214143155
LGTM. Code Reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r60852850
--- Diff: engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java ---
@@ -962,35 +962,59 @@ public boolean removeBy(Short capacityType
Github user sudhansu7 commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-213954430
@DaanHoogland
Thanks for the review. I have made necessary changes. I think in t=your
test setup op_host_capacity does not have capacity details, for which t
Github user sudhansu7 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r60844257
--- Diff: engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java ---
@@ -962,35 +962,58 @@ public boolean removeBy(Short capacityType, Long
zone
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-213825554
regression suite passed:
[1516.results.network.txt](https://github.com/apache/cloudstack/files/233136/1516.results.network.txt)
[1516.results.vpc_
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r60826448
--- Diff: engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java ---
@@ -962,35 +962,58 @@ public boolean removeBy(Short capacityType, Long
z
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1516#discussion_r60826329
--- Diff: engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java ---
@@ -962,35 +962,58 @@ public boolean removeBy(Short capacityType, Long
z
GitHub user sudhansu7 opened a pull request:
https://github.com/apache/cloudstack/pull/1516
CLOUDSTACK-9366: Capacity of one zone-wide primary storage ignored
Disable and Remove Host operation disables the primary storage capacity.
Steps to replicate:
Base Condition: The
42 matches
Mail list logo
