[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1513 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-18 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-220025750 The tests that were failing are not failing anymore, I think this is ready... --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-18 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-220025466 ### CI RESULTS ``` Tests Run: 44 Skipped: 0 Failed: 0 Errors: 0 Duration: 3h 20m 40s ``` **Associ

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-17 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219874903 I will rerun tests now... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-17 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219874035 @swill Sure you haven't got some artifacts left behind from some other testing? This is only a libvirt hook, so I can't imagine how the tests failing above could

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-17 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219820368 Not sure what to think of that. I have never seen those errors before in my environment... --- If your project is set up for it, you can reply to this email and hav

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-17 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219820026 ### CI RESULTS ``` Tests Run: 44 Skipped: 0 Failed: 3 Errors: 0 Duration: 3h 12m 14s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-17 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219709059 We are green now. 👍 I am going to rerun CI to make sure the Failure we got does not pop up again. Otherwise we are pretty good. Thanks... --- If your project i

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-17 Thread insom
Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219663341 @swill rebased and pushed. It does have two LGTMs and tests by real people (plus it's in production at here at iWeb) if that makes it a little easier to overrule Jenk

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-16 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219537126 @insom we are down to the wire here. I would like to see if we can get this green and merge it before the freeze. Can you rebase and push again to kick the automati

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219109520 Holy errors batman!!! It looks like it started like this: ``` [INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ cloud-server

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread insom
Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219101084 @swill Hmm. Now it's a _different_ Cobertura error --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219091474 @insom yes, I tend to agree with you. the main reason I highlighted it was because the error was network related and the code changed details related to an interface

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread insom
Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219085734 @swill I've closed and re-opened. This change is to a shell script only and the failures are within Marvin, so I'm pretty confident that they are unrelated to my prop

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread insom
Github user insom closed the pull request at: https://github.com/apache/cloudstack/pull/1513 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread insom
GitHub user insom reopened a pull request: https://github.com/apache/cloudstack/pull/1513 CLOUDSTACK-9362: Skip VXLANs when rewriting the bridge name for migrations (4.8-2) From the [JIRA issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9362): > https://github.com/

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219084969 @insom, @dmabry and @kiwiflyer, the CI failure seems like it could be related to this change, but I can't be sure. Can you guys provide some guidance since all of yo

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219084090 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 1 Errors: 0 Duration: 9h 01m 07s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-12 Thread dmabry
Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-218764129 Also, tested in a 4.8 lab and I was able to migrate VMs between hosts when using VXLAN Guest Isolated network. LGTM --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-03 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-216709951 Tested this in a hardware 4.8 lab: I was able to migrate VXLAN enabled VMs between hosts as expected. LGTM --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-28 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-215549283 We'll pull this in for testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread insom
Github user insom closed the pull request at: https://github.com/apache/cloudstack/pull/1512 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

RE: [GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread Richard Klein (RSI)
ay, April 22, 2016 9:21 AM > To: dev@cloudstack.apache.org > Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs > when rewriti... > > GitHub user insom opened a pull request: > > https://github.com/apache/cloudstack/pull/1513 > > CLOUDSTACK-

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread insom
GitHub user insom opened a pull request: https://github.com/apache/cloudstack/pull/1513 CLOUDSTACK-9362: Skip VXLANs when rewriting the bridge name for migrations (4.8-2) From the [JIRA issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9362): > https://github.com/ap

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1512#issuecomment-213443134 You opened it against master again... ![image](https://cloud.githubusercontent.com/assets/13644/14743978/7e8dbfd6-0872-11e6-83bc-73ebe2699a9c.png) --- If

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread insom
Github user insom closed the pull request at: https://github.com/apache/cloudstack/pull/1508 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread insom
Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/1508#issuecomment-213441018 #1512 is the new version of this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread insom
GitHub user insom opened a pull request: https://github.com/apache/cloudstack/pull/1512 CLOUDSTACK-9362: Skip VXLANs when rewriting the bridge name for migrations (4.8) From the [JIRA issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9362): > https://github.com/apac

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1508#issuecomment-213439120 @insom, yes @kiwiflyer is correct. You will need to base your change off the 4.8 branch and close this PR and open a new PR based off the 4.8 branch. Thanks for the

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1508#issuecomment-213434581 @insom Yes, rebase it against the 4.8 branch and yes you'll need to issue a new PR and close this one. --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread insom
Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/1508#issuecomment-213431813 @swill Thanks! Should I rebase this against the latest 4.8 branch then? I don't think I can change where a PR is based against, so I think I'd need to open a new PR -

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1508#issuecomment-213431039 @kiwiflyer if you wouldn't mind posting the results of your tests that would be appreciated. :) @insom if this was actually introduced in 4.8, I agree that w

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1508#issuecomment-213428079 @insom Thanks for the PR. We'll pull this in for testing as we use vxlan. As it looks like this bug was introduced in 4.8, I'd suggest you may want to iss

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-21 Thread insom
GitHub user insom opened a pull request: https://github.com/apache/cloudstack/pull/1508 CLOUDSTACK-9362: Skip VXLANs when rewriting the bridge name for migrations From the [JIRA issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9362): > https://github.com/apache/clou