[GitHub] cloudstack pull request: CLOUDSTACK-9352: Test fails in Widows as ...

2016-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1498 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9352: Test fails in Widows as ...

2016-04-21 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1498#issuecomment-212985885 That is what I was looking for. Thank you sir... :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9352: Test fails in Widows as ...

2016-04-21 Thread GabrielBrascher
Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1498#issuecomment-212984070 @swill it succesfully builds in windows: [build-result.txt](https://github.com/apache/cloudstack/files/230237/build-result.txt); Not sure it if help

[GitHub] cloudstack pull request: CLOUDSTACK-9352: Test fails in Widows as ...

2016-04-21 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1498#issuecomment-212964858 I need one more LGTM and if you can post some proof this is working as expected, I will feel better about merging it. Thanks... :) --- If your project is set up fo

[GitHub] cloudstack pull request: CLOUDSTACK-9352: Test fails in Widows as ...

2016-04-21 Thread cloudsadhu
Github user cloudsadhu commented on the pull request: https://github.com/apache/cloudstack/pull/1498#issuecomment-212828874 reviewed your code change and looks good. Please post the test result. LGTM based on code review !! --- If your project is set up for it, you can reply to t