Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1496
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-218056068
Thanks for confirming @koushik-das. ð It is the middle of the night
right now, so I am fading fast.
---
If your project is set up for it, you can reply to thi
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-218048251
@swill The failures doesn't look related to this PR. This can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-217884184
The two failures are not ones I am used to seeing in my environment, but I
did a quick once through of the code and I don't think they problem is related
to this PR.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-217772228
### CI RESULTS
```
Tests Run: 88
Skipped: 2
Failed: 1
Errors: 1
Duration: 11h 25m 09s
```
**Summary of the
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-216228687
LGTM (code review)
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-215890052
LGTM for code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1496#discussion_r61649158
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -264,6 +265,11 @@ public void scheduleRestartForVmsOnHost(final HostVO
host, b
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-215651932
@swill rebased it. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-215552813
@abhinandanprateek please rebase as this currently has merge conflicts with
master. Thanks...
---
If your project is set up for it, you can reply to this email and
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-215026662
Code changes LGTM, verified changes in HighAvailabilityManagerImpl.java.
Someone else needs to verify KVM related changes.
---
If your project is set up for it
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1496#discussion_r60004052
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -264,6 +265,11 @@ public void scheduleRestartForVmsOnHost(final Ho
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-211149034
@abhinandanprateek How about extracting lines 70-82 in `KVMInvestigator` to
their own method? I think it would be nice to get a test case going for that
sectio
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-210619709
@abhinandanprateek Jenkins failed due to no license header in the new test
case, test_host_ha.py. Travis failed because it could not find the Marvin egg.
---
If
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-210422617
Marvin output with only Local storage:
49b-b201830aec39
VirtualMachine on Hyp 1 = 1d500ef3-ef56-4d11-91d8-c0e37f015236
VirtualMachine on Hy
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-210422584
Marvin test output for NFS PS:
hine on Hyp 1 = 228dc462-ceab-4225-8d35-5749cbb593c2
VirtualMachine on Hyp 1 = 2caf838f-016f-4cf6-9d35-67a2e1398
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1496
CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost for Local storage
- KVM-HA- Fix CheckOnHost for Local storage
- Also skip HA on VMs that are using local storage
You can merge this pu
17 matches
Mail list logo
