[GitHub] cloudstack pull request: CLOUDSTACK-9348: Optimize NioTest and Nio...

2016-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Optimize NioTest and Nio...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1534#issuecomment-217521378 I am not concerned about the two failures. One happens randomly in my environment and one is a cleanup issue between test runs which is not related to this PR.

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Optimize NioTest and Nio...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1534#issuecomment-217519767 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 2 Errors: 0 Duration: 4h 31m 04s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Optimize NioTest and Nio...

2016-05-06 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1534#issuecomment-217442413 LGTM based on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Optimize NioTest and Nio...

2016-05-06 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1534#issuecomment-217413262 @swill this PR is ready for CI test run and merge, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Optimize NioTest and Nio...

2016-05-05 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1534#issuecomment-217287468 @swill thanks for sharing, I made the NioConnection's main IO loop aggressive and reduced the SSL handshake timeout to 15s (this was previously 10s, but over last yea

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Optimize NioTest and Nio...

2016-05-05 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1534#issuecomment-217278185 Well the test runs a lot faster/cleaner now. 👍 ``` Running com.cloud.utils.testcase.NioTest 2016-05-05 22:53:54,828 INFO [utils.testcase.NioTest]

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Optimize NioTest and Nio...

2016-05-05 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1534#issuecomment-217226501 @DaanHoogland @jburwell @wido @swill and others -- please review, this mainly fixes the NioTest which was failing so if it's okay and works for Travis and Will's CI l

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Optimize NioTest and Nio...

2016-05-05 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1534 CLOUDSTACK-9348: Optimize NioTest and NioConnection main loop - Reduces SSL handshake timeout to 15s, previously this was only 10s in commit debfcdef788ce0d51be06db0ef10f6815f9b563b - Ad