Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207543327
Create new PR #1480 in 4.7 branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
GitHub user Slair1 opened a pull request:
https://github.com/apache/cloudstack/pull/1480
CLOUDSTACK-9342: Site to Site VPN PFS not being set correctly
Bug in code set PFS to the same value (yes/no) as DPD.
file.addeq(" pfs=%s" % CsHelper.bool_to_yn(obj['dpd']))
You can merg
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207533662
@Slair1 If you create a new PR or if a different PR solves the problem you
ran into, can you please post the PR number that replaces this one? This helps
me maintain
Github user Slair1 closed the pull request at:
https://github.com/apache/cloudstack/pull/1478
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207531252
@Slair1 You should have a close button below the comments section.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207531359
@kiwiflyer , wow i feel stupid now :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207530559
@kiwiflyer thanks, how do i delete this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207528583
@Slair1 You can checkout the 4.7 branch and then create a new branch. Apply
the patch and then push that new local branch back up to your github ACS fork.
Then cr
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207526795
ah, thanks @kiwiflyer . How do i change this to 4.7.x?
Also i check PR #872 and the PFS code looks good there, it is totally
re-written.
---
If your proje
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207524802
PR https://github.com/apache/cloudstack/pull/872 is going to replacing
openswan with strongswan.
I believe PFS is depreciated in strongwan, so it might ma
GitHub user Slair1 opened a pull request:
https://github.com/apache/cloudstack/pull/1478
CLOUDSTACK-9342: Site to Site VPN PFS not being set correctly
Bug in code set PFS to the same value (yes/no) as DPD.
file.addeq(" pfs=%s" % CsHelper.bool_to_yn(obj['dpd']))
You can merg
11 matches
Mail list logo
