Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1452
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-214211132
@swill I think this one has enough LGTM and testing and the only question I
see remaining has been answerred. @pedro-martins is not responded anymore so
let's
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-214209793
@DaanHoogland, We haven't heard from @pedro-martins in a while. Let's hope,
he responds soon (or) someone form the community reviews our code.
---
If your p
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211453267
@pedro-martins can you live with the present state?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211370314
I think this is ready pending 1 more LGTM code review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-26802
@DaanHoogland That's a good suggestion. We will discuss on the optimal
location in the plugin's project directory, and incorporate them in the next PR.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211099345
@swill LGTM based on testing and code walkthrough
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211099195
@prashanthvarma maybe you can incorporate it in the project dir for the
plugin somehow. It seems to me to be the best place for it. maybe accompanied
with a re
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211092880
@DaanHoogland you are right, that is the main motive :). Let me know, if
you want me to publish it elsewhere as well for easier user access.
Thank yo
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211060040
thanks @prashanthvarma , mostly usefull for users of your sdn solution.
Hopefully some of them will test ;)
---
If your project is set up for it, you can repl
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211044426
@DaanHoogland Sure, here is an example Nuage VSP SDN plugin specific Marvin
tests config file contents:
{
"zones": [
{
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211038147
@prashanthvarma can you publish nuage_ant.cfg?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211032986
did the tests and again two failures, replay succeeded
[1452.results.network.txt](https://github.com/apache/cloudstack/files/222681/1452.results.networ
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-210849171
started the suite now but keep in mind that no sdn specific tests are done
in it, @swill
---
If your project is set up for it, you can reply to this email a
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-210646612
It seems to be in pretty good order. I would like some code reviews and
since there are changes to logic outside of the tests, I would like a full CI
run against it.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-210643703
@KrisSterckx I think so but not sure. @swill can you put this in?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-210464551
Hi @DaanHoogland is this PR still in the candidate list of 4.9.0 ?
If there is anything that I & the team can facilitate in doing, pls let me
know.
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-203794406
@pedro-martins, I do like it, but we didn't change that code, we just
restructured it a bit so I didn't want to touch the original code, I can still
make that chang
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-203581569
@nlivens great! And sorry for the delay =)
I saw that you used the String.format as I suggested, but and about the
using of CollectionUtils.isEmpty() in th
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-202859071
@pedro-martins Updated the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-202163598
Hi @prashanthvarma.
How about to use String.format() to create the strings in the loggers? The
use of String format will turn the strings in the logs
GitHub user prashanthvarma opened a pull request:
https://github.com/apache/cloudstack/pull/1452
CLOUDSTACK-9322: Support for Internal LB fuctionality with Nuage VSP SDN
Plugin including Marvin tests
Task: https://issues.apache.org/jira/browse/CLOUDSTACK-9322
PR contents:
22 matches
Mail list logo
