Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1431#issuecomment-197920029
It was already merged. I will leave it for now, but I will take note of
this PR to validate it once my CI is up and running to make sure it does not
cause any issues
Github user chinu2909 commented on the pull request:
https://github.com/apache/cloudstack/pull/1431#issuecomment-197539050
LGTM based on the test results
test_01_UserDataPasswordReset
(nuagevsp.test_nuage_password_reset.TestNuagePasswordReset) ... === TestName:
test_01_UserDa
Github user srikanteswartalluri commented on the pull request:
https://github.com/apache/cloudstack/pull/1431#issuecomment-197905351
If the concern is jenkins build, I mentioned that they are not related to
these integration test code but they are junit tests.
---
If your project is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1431#issuecomment-197903262
I am not going to revert this merge at this time, but please ping me if you
feel the PR is ready to be merged into master. Thx...
---
If your project is set up for
Github user srikanteswartalluri commented on the pull request:
https://github.com/apache/cloudstack/pull/1431#issuecomment-197904292
@swill Yes, PR is ready to be merged. Do you see any problem with that?
---
If your project is set up for it, you can reply to this email and have your
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1431
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srikanteswartalluri commented on the pull request:
https://github.com/apache/cloudstack/pull/1431#issuecomment-197927026
sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user srikanteswartalluri commented on the pull request:
https://github.com/apache/cloudstack/pull/1431#issuecomment-196653502
otherwise, it LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user srikanteswartalluri commented on the pull request:
https://github.com/apache/cloudstack/pull/1431#issuecomment-196653459
Jenkins failure is not related to these integration test changes, there are
some junit tests failed
[ERROR] Failed to execute goal
org.apache.m
Github user sneeladh commented on the pull request:
https://github.com/apache/cloudstack/pull/1431#issuecomment-196593964
Pep8 and Pyflakes compliant
[sneeladh@mvlinux26:nuagevsp]$
[sneeladh@mvlinux26:nuagevsp]$ pep8 --max-line-length=150
test_nuage_password_reset.py
Github user srikanteswartalluri commented on the pull request:
https://github.com/apache/cloudstack/pull/1431#issuecomment-195391894
@sneeladh @shivsg Thanks for adding the tests, can you please run your
code through pyflakes, pep8 and fix them ?
$ pyflakes *.py
nuageTest
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1431#issuecomment-195224152
LGTM based on the code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user sneeladh commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1431#discussion_r55789682
--- Diff: test/integration/component/test_nuage_vsp.py ---
@@ -1,334 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or
Github user shivsg commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1431#discussion_r55776272
--- Diff: test/integration/component/test_nuage_vsp.py ---
@@ -1,334 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or mo
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1431#discussion_r55646437
--- Diff: test/integration/component/test_nuage_vsp.py ---
@@ -1,334 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or
Github user shivsg commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1431#discussion_r55638247
--- Diff: test/integration/component/test_nuage_vsp.py ---
@@ -1,334 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or mo
Github user shivsg commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1431#discussion_r55638203
--- Diff: test/integration/component/test_nuage_vsp.py ---
@@ -1,334 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or mo
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1431#discussion_r55635511
--- Diff: test/integration/plugins/nuagevsp/test_nuage_vpc_network.py ---
@@ -0,0 +1,98 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1431#discussion_r55635451
--- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py ---
@@ -0,0 +1,830 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1431#discussion_r55635262
--- Diff: test/integration/component/test_nuage_vsp.py ---
@@ -1,334 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1431#discussion_r55635106
--- Diff: test/integration/component/test_nuage_vsp.py ---
@@ -1,334 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or
GitHub user sneeladh opened a pull request:
https://github.com/apache/cloudstack/pull/1431
CLOUDSTACK-9304: Add nuagevsp userdata testcase (Cloudstack-9095) &
Refactor existing testcases
https://issues.apache.org/jira/browse/CLOUDSTACK-9304
1. Created folder / test / integr
22 matches
Mail list logo
