Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204397261
Yes I meant to post the results, but I was too quick trying to get thing
setup for the next run and I blew away my environment. :( Im a noob... I
will be posting t
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204382745
@swill Congrats on the first bubble-tested PR :-) I would recommend posting
the results though, the results.txt file shows which tests were run. If later
we wan
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204216991
My tests verified that this was ready to merge. Merged...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1425
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204025586
nice thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204025261
**Minimal**
CPU Intel 4 core 64-bit processor with virtualization extensions
RAM 16GB
HDD 20GB
**Recommended**
CPU Intel Skylake 4 core 64-bit
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204019262
That is cool. This will certainly be a great benefit to our community.
What are the resources (CPU, memory, HD) requirements to run this appliance?
-
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204016332
I am hoping to get things more automated as I get more comfortable with
everything, but I just had to get something in place so I can start getting
through this PR ba
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204015782
Sure it answered ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204015303
I have to manually kick off the PRs for now, I have not automated it yet.
Still getting going.
It is deployed as hypervisor on hypervisor using bubble, so it
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204013813
Out of curiosity, is it running automatically testing all of the opened PRs?
Curiosity 2, is it real hardware or a buble?
---
If your project is set
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204011495
Testing my first PR with my shiny new CI environment. :P
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204011239
ok thanks ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204010549
I am running tests against real hardware right now for this. Assuming
everything goes will I will merge it right after. Thx...
---
If your project is set up for it
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204008304
Did we run the whole BVT test suite on it as well? I see a few integration
test run, but not many. If we think it is ready to go, I can merge it in...
---
If your
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204005766
I guess so, if no one objects.
The code was extensively reviewed, test cases (unit ones) were written,
functional test were executed. For me this
Github user serg38 commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-204005079
Great!!! 2 LGTM received. Can we have this merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-203654592
@nvazquez, Nice changes, great job refactoring your implementation. I found
no more troubles in this PR, then LGTM.
Ty.
---
If your project is set u
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-202498197
Thanks @rafaelweingartner!
@pedro-martins could you review the last changes?
---
If your project is set up for it, you can reply to this email and have your
re
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-198518585
Hi @rafaelweingartner, I also ran
test/integration/smoke/test_templates.py, I post its results:
[root@ussarlabcsmgt41 cloudstack]# cat
/tmp/Marvi
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-198519031
@nvazquez that is great. I can give an LGTM now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-195747270
@nvazquez thanks for running the functional tests...
I was wondering, is there any Marvin tests for templates and volumes
(backup, creation and others)
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-195463133
I post my test results for test_vm_lifecycle.py
[root@ussarlabcsmgt41 cloudstack]# nosetests --with-marvin
--marvin-config=setup/dev/advanced.cfg
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-195366204
@nvazquez now everything seems ok
Could you run integration tests?
---
If your project is set up for it, you can reply to this email and have your
rep
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-195308535
@rafaelweingartner it was my mistake, I had writen user_vm__view instead of
user_vm_view on the script. I fixed it and pushed again
---
If your project is set up
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-195305570
Now the error changed.
It is in another table and probably is not related to your work.
Now the problem is with "user_vm_view"
Could you track w
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-195303532
Thanks @rafaelweingartner
I removed those lines but still not working:
[ERROR] Failed to execute goal
org.codehaus.mojo:exec-maven-plugin:1.2.1:j
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-195093089
@nvazquez the code is ok now.
I believe the problems you are having are due to lines 27, 28 and 29; I
think you can remove them.
---
If your project
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-194884875
Hi @rafaelweingartner @pedro-martins,
I see continuous integration check is still failing due to this error, I
made some changes in setup/db/db/schema-481t
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1425#discussion_r55044070
--- Diff:
server/test/com/cloud/api/query/dao/GenericDaoBaseWithTagInformationBaseTest.java
---
@@ -0,0 +1,59 @@
+// Licensed to the Apache Softwar
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-192324826
Done @pedro-martins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1425#discussion_r55043711
--- Diff:
server/src/com/cloud/api/query/dao/GenericDaoBaseWithTagInformation.java ---
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundati
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-192288498
@pedro-martins Sure, I'll push some changes that @rafaelweingartner pointed
out and squash them all into one
---
If your project is set up for it, you can reply t
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-192286165
@nvazquez.
Could you squash all of yours commits into one? It's hard to compare the
original code with your current modifications. If you do not know
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1425#discussion_r54969574
--- Diff:
server/test/com/cloud/api/query/dao/GenericDaoBaseWithTagInformationBaseTest.java
---
@@ -0,0 +1,59 @@
+// Licensed to the Apach
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1425#discussion_r54964238
--- Diff:
server/src/com/cloud/api/query/dao/GenericDaoBaseWithTagInformation.java ---
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-191930272
@rafaelweingartner @pedro-martins I followed your suggestions and made a
big refactor, hope this would be better now. I'm planning to run integration
tests and pos
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-191455410
@nvazquez I have reviewed your code.
Class âVolumeJoinDaoImplâ at line 46, why did you change the get Logger
method to use âVolumeJoinDaoImplTest
Github user pedro-martins commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1425#discussion_r54797480
--- Diff: server/test/com/cloud/api/query/dao/TemplateJoinDaoImplTest.java
---
@@ -0,0 +1,56 @@
+package com.cloud.api.query.dao;
+
+im
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-191393797
@rafaelweingartner @pedro-martins thanks for your comments! I deleted the
constructor and used setters instead and not included the Builder pattern, but
if you wan
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-190961759
@nvazquez and @pedro-martins,
I am ok with the code now, expect the constructor bit.
The question you should ask about the constructor is, is it us
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-190874260
@nvazquez
I mean unit tests for each new method.
I think that use the Builder to get an instance with all variables
initialized is a good w
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-190853930
Hi @pedro-martins thanks for your comments!
About test cases you mean unit tests or an integration test for this
changes?
I planned to use that constructor
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-190791313
@nvazquez, nice changes.
So, I guess that a test cases for these new methods will be important to
detect future changes in these methods behavior.
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-190753666
Hi @rafaelweingartner,
Sure, I changed it to a method and added javadoc to it.
I added the new constructor at ResourceTagJoinVO to set all
that fi
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-190430298
@nvazquez ,
Lines 191-195 and 261-265 are duplicated, could you extract it to a method?
And maybe even document it.
At the âResourceTagJoin
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1425
CLOUDSTACK-9298: Improve performance of resource retrieval that have tags
associated and target volumes, VMs and templates
JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9298
47 matches
Mail list logo
