Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200956335
@swill Yes, I'll work on this either today or tomorrow and get a new PR
submitted.
Thanks guys.
---
If your project is set up for it, you can reply to t
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200936609
Thank you sir. I really appreciate it. Once I get my CI online I will be
able to start getting through this backlog in a much more efficient manner.
---
If your pr
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200931266
You are welcome.
I try to go over as many PRs as I can, but I always end up overlooking
some. You can always ping me on slack or mail to check a PR bef
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200926830
@rafaelweingartner I agree. I think it makes the most sense to open a new
PR to add the exception log. @kiwiflyer would you mind doing that for us?
Would you mind
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200919876
@kiwiflyer, it is nice that we achieved a consensus.
What do you think @swill?
How do we proceed now? This PR has already been merged and forw
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200918379
@rafaelweingartner Yes, you are correct. I like your suggestion. I'll log
the exception with the failure.
In terms of the persistent connections, I believ
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200914880
Ok,
So, this agent class is executed as a service in the operating system (OS)
the OS will call a service that calls the main method that instantiates
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200908383
@swill This exception is thrown when the NIO operations used to establish
the connection to the management server on port 8250 fail.When this exception
gets thro
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200906752
@rafaelweingartner This is used in both the system VM agent and the host
(hypervisor) agent.
---
If your project is set up for it, you can reply to this em
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200905706
That is it;
Well, giving that the â_shell.getBackoffAlgorithm().waitBeforeRetry()â
uses a parameter that indicates the amount of time between retr
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200903313
so you are basically saying that if the connection can not be established,
it is not functional anyway, so there is no point in this timing out?
---
If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200897012
I see your point and I agree with you. What do you think is a reasonable
amount of time to check before we throw the error?
---
If your project is set up for it, yo
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200901622
I want to point out that this is taking care of the case where you have a
load balancer between the agents and the management server (see original issue
notes). I
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200888647
The test output you mean was the one posted by @kiwiflyer ?
I had not reviewed this PR (sorry for that), but there are two (2) things
here that called
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200884247
i will make sure that integration test are run against everything going
forward. this judgment call may have been premature.
---
If your project is set up for it, y
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200883526
output was posted for test run against master and 4.7. maybe I jumped the
gun?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200882489
this was merged without functional tests (integration tests)?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-199787555
@swill dear RM, can we merge this in 4.7 and merge forward
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-199787161
LGTM based on field experience and code inspection
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-199787118
Test log for reconnect scenerio:
Agent throws an exception that can never be recovered from when the agent
attempts to reconnect and is sent a RST. This c
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-197556331
@kiwiflyer 3683dff LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-198239218
stop the management server, and restart cloudstack-agent during the
stopping.
1. without the commit 3683dff :
```
2016-03-17 21:25:26,359 ERROR
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-193851127
@ustcweizhou Does 3683dff work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-193827846
@kiwiflyer code LGTM.
can you
(1) squash the commits,
(2) add a space before s_logger.info ? We use 4 space indentation in java.
---
If your proje
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-193820061
@ustcweizhou I've cleaned up the other 2 exceptions and also removed the
newline you pointed out eariler.
---
If your project is set up for it, you can reply to
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-193813489
@kiwiflyer Simon, I agree with you. Besides your change, we also need to
fix similar issue in line 230/238.
Actually line 230 caused the issue described in
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-193796033
@ustcweizhou
So after looking at our issue and the one reported originally in 9285, I
think they're two different issues. One related to initial connection on
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-193648204
@kiwiflyer this is the log in jira:
```
2016-02-15 10:46:21,611 INFO [utils.exception.CSExceptionErrorCode]
(main:null) (logid:) Could not find exc
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-193508523
@ustcweizhou Thanks for the advice. Maybe I can catch you on the slack
channel tomorrow to discuss a little, so I better understand the logic between
start and re
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1430#discussion_r55286730
--- Diff: agent/src/com/cloud/agent/Agent.java ---
@@ -412,7 +412,8 @@ protected void reconnect(final Link link) {
try {
GitHub user kiwiflyer opened a pull request:
https://github.com/apache/cloudstack/pull/1430
CLOUDSTACK-9285 for 4.7.x
Per Daan's request, here is a pull request for the 4.7.x release.
You can merge this pull request into a Git repository by running:
$ git pull https://github.co
32 matches
Mail list logo
