[GitHub] cloudstack pull request: CLOUDSTACK-9285 - Agent throws an excepti...

2016-03-19 Thread kiwiflyer
Github user kiwiflyer closed the pull request at: https://github.com/apache/cloudstack/pull/1429 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9285 - Agent throws an excepti...

2016-03-19 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1429#issuecomment-198513018 Closing this PR, as this issue has been address more cleanly in my other PR against 4.7 - https://github.com/apache/cloudstack/pull/1430 --- If your project is s

[GitHub] cloudstack pull request: CLOUDSTACK-9285 - Agent throws an excepti...

2016-03-07 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1429#issuecomment-193384072 @kiwiflyer Thanks, have seen this as well and will try your fix when I have some time :-) --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9285 - Agent throws an excepti...

2016-03-07 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1429#issuecomment-193220496 @kiwiflyer Simon, I'm a nag but can you recreate this PR against 4.7? We've confirmed it on 4.7 s well. I think it was introduced in 4.6 even but that release

[GitHub] cloudstack pull request: CLOUDSTACK-9285 - Agent throws an excepti...

2016-03-06 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1429#issuecomment-192913591 Daan, Sorry about that. I've fixed it, pushed the commit and checks are now passing. Simon --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9285 - Agent throws an excepti...

2016-03-06 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1429#issuecomment-192864151 @kiwiflyer your change makes sense to me, (un)fortunately we have quite strict checkstyle settings. Can you replace the tab with spaces? --- If your project i

[GitHub] cloudstack pull request: CLOUDSTACK-9285 - Agent throws an excepti...

2016-03-04 Thread kiwiflyer
GitHub user kiwiflyer opened a pull request: https://github.com/apache/cloudstack/pull/1429 CLOUDSTACK-9285 - Agent throws an exception on reconnect and fails Agent throws an exception that can never be recovered from when the agent attempts to reconnect and is sent a RST. This cas