[GitHub] cloudstack pull request: CLOUDSTACK-9283: add pid to java argument...

2016-04-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1409 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9283: add pid to java argument...

2016-04-28 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1409#issuecomment-215409715 Tested this in a 4.8 lab. I agree that there is little point in running CI against this, as it's a config change. LGTM. --- If your project is set up f

[GitHub] cloudstack pull request: CLOUDSTACK-9283: add pid to java argument...

2016-04-27 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1409#issuecomment-214994528 @swill agree --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack pull request: CLOUDSTACK-9283: add pid to java argument...

2016-04-26 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1409#issuecomment-214966321 Two people have confirmed this is working and we also have two LGTM. Is this one ready to merge. I don't think running CI is going to add much value beyond the manu

[GitHub] cloudstack pull request: CLOUDSTACK-9283: add pid to java argument...

2016-03-19 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1409#issuecomment-197771350 LGTM works fine in our internal version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cloudstack pull request: CLOUDSTACK-9283: add pid to java argument...

2016-03-09 Thread Slair1
Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1409#issuecomment-194409665 I applied to my 4.8 source and repackaged and installed, it worked. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: CLOUDSTACK-9283: add pid to java argument...

2016-03-09 Thread Slair1
Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1409#issuecomment-194394917 FYI, this fix also worked for me, Cloudstack 4.8 on Centos7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9283: add pid to java argument...

2016-02-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1409#discussion_r52551673 --- Diff: packaging/systemd/cloudstack-usage.service --- @@ -27,10 +27,11 @@ Environment=JAVA_HOME=/usr/lib/jvm/jre Environment=JAVA_HEAP_INITIAL=25

[GitHub] cloudstack pull request: CLOUDSTACK-9283: add pid to java argument...

2016-02-10 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1409#issuecomment-182446008 proof that this works in centos 7.2 running cloudstack 4.7.1: ``` # cat /etc/redhat-release CentOS Linux release 7.2.1511 (Core)

[GitHub] cloudstack pull request: CLOUDSTACK-9283: add pid to java argument...

2016-02-10 Thread davidamorimfaria
GitHub user davidamorimfaria opened a pull request: https://github.com/apache/cloudstack/pull/1409 CLOUDSTACK-9283: add pid to java arguments in cloudstack-usage.service cloudstack-usage fails to start throwing Integer exception during PID retrieval, and the service keeps restarting