[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

2016-04-19 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1394#issuecomment-211958527 @koushik-das oh, i understand your question better now. i would like to do it on every commit. It makes the commit history clearer and it mitigates conflict issues.

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

2016-04-19 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1394#issuecomment-211954088 @swill I wanted to understand if it is ok to do these fwd merges once every week/fortnight (based on number of commits that went into the release branch) or do

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

2016-04-19 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1394#issuecomment-211947137 Every commit that goes into 4.7 gets fwd-merged into 4.8 and then gets fwd-merged into master. We have tools in `cloudstack/tools/git/` which make this process MUCH

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

2016-04-19 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1394#issuecomment-211943539 @swill I didn't fwd merge into 4.8 and master. Are we fwd merging for every individual commit in order to avoid conflicts? --- If your project is set up for it

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

2016-04-19 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1394#issuecomment-211926700 @koushik-das I am not seeing the commit in master. Did you merge into 4.7 and then forward merge into 4.8 and then forward merge into master??? --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

2016-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1394 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

2016-04-19 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1394#issuecomment-211864757 Merging as UI change and 2 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

2016-03-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1394#issuecomment-192299327 LGTM, code is trivial and functionality intuitive --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

2016-03-04 Thread glennwagner
Github user glennwagner commented on the pull request: https://github.com/apache/cloudstack/pull/1394#issuecomment-192290945 LGTM - Tested and working correctly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

2016-02-02 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1394#issuecomment-178716448 Before Fix: = ![before fix - nitin](https://cloud.githubusercontent.com/assets/12583725/12758734/c3c0a486-ca03-11e5-9a87-23556d249aaa.jpg)

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

2016-02-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1394#issuecomment-178706035 @nitin-maharana can you add a screenshot of the intended change? --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

2016-02-02 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1394 CLOUDSTACK-9268: Display VM in Load balancing rule in UI Steps of Repro: = 1:Create VMs 2:Make LoadBalancing rule in GUI  Name:WWW  PrivatePort:80