Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1567
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1567#issuecomment-23495
This is coming back clean. I will merge it...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1567#issuecomment-22745
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 3h 56m 33s
```
**Associ
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1567#issuecomment-222141588
Ok, this is building in my CI environment right now, so I will see if it
fails for me as well. Thx...
---
If your project is set up for it, you can reply to this em
Github user footplus commented on the pull request:
https://github.com/apache/cloudstack/pull/1567#issuecomment-222140436
Seems to break the registerIso command here... Will check exactly why.
``
2016-05-27 15:01:14,211 ERROR [c.c.a.ApiServer]
(catalina-exec-1:ctx-56423a5c
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1567#issuecomment-222099870
ahh.. my bad.. thanks for the clarification.
so, we need to introduce a new CommandType.URL for api parameters and use
java.net.URL in VOs.
LGTM in the
Github user marcaurele commented on the pull request:
https://github.com/apache/cloudstack/pull/1567#issuecomment-222094671
Because not all varchar columns have been updated to a length of 2048 in
the DB, so there will be a mismatche between API, VO and the database.
---
If your proj
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1567#discussion_r64875174
--- Diff: setup/db/db/schema-471to480.sql ---
@@ -27,3 +27,4 @@ ALTER TABLE `cloud`.`image_store` MODIFY COLUMN `url`
varchar(2048);
ALTER TABLE `c
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1567#issuecomment-222093757
Why dont we change the default length in
[GenericDaoBase](https://github.com/apache/cloudstack/blob/master/framework/db/src/com/cloud/utils/db/GenericDaoBase.jav
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1567
CLOUDSTACK-9238: Fix URL length to 2048 for all url fields in VO
I will update the PR to add max field length in the API commands too
You can merge this pull request into a Git repository by
10 matches
Mail list logo
