[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

2016-05-27 Thread wido
Github user wido closed the pull request at: https://github.com/apache/cloudstack/pull/1562 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

2016-05-26 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221904814 ### CI RESULTS ``` Tests Run: 82 Skipped: 0 Failed: 0 Errors: 3 Duration: 8h 17m 54s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

2016-05-26 Thread footplus
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221893016 Maybe you meant to change on this table: `` alter table `vm_template` modify column `url` varchar(2048) DEFAULT NULL COMMENT 'the url where the templat

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

2016-05-26 Thread footplus
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221876586 @wido I have the 255-chars problems here too, and this particular table is empty; did you add a patch on the API too to unlock the API limitation to 255 chars ?

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

2016-05-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221825423 commit 5c35bd1b3e0184842ed80a9c465549c2a61f5fd9 copied all the data from template_host_ref to template_store_ref --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

2016-05-26 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221823209 @karuturi Are you sure about that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

2016-05-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221821581 This table is not used anymore. the table should be dropped. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

2016-05-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221538713 LGTM, simple fix. Tested on local database. tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

2016-05-25 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221538332 @rhtyd: Could you take a look? As you can see, it's a very small fix. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

2016-05-25 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221531859 @swill: Still time to get this one in? This fix is running in production on our clouds. It is just a ALTER TABLE to increase the size of a database field. --

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

2016-05-25 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1562 CLOUDSTACK-9238: Change template_host_ref.url to varchar(2048) In Pull Request #1341 / commit a171bb this was fixed for many other URL fields, but this was not corrected and is still a varchar(