[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

2016-01-20 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1338#issuecomment-173436054 Thanks @remibergsma. Sorry I saw your comments bit late. You have already figured it out. Thanks @DaanHoogland --- If your project is set up for it, you ca

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

2016-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1338 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

2016-01-19 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1338#issuecomment-172966645 I have some remarks about style (made one) but the logic looks fine. LGTM --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

2016-01-18 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1338#issuecomment-172545747 LGTM based on these tests: Situation before when not using Netscaler: ![screen shot 2016-01-18 at 15 37 25](https://cloud.githubusercontent.com

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

2016-01-18 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1338#issuecomment-172537670 @nitin-maharana I like it when you put screenshots, as this speeds up my testing because I can see what you mean. I will test it soon, can you help me by puttin

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

2016-01-13 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1338#issuecomment-171381086 @rafaelweingartner : Super I will make the modification on both PRs. Thanks. --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

2016-01-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1338#issuecomment-171379436 @nitin-maharana, if you create the function I suggested you to create in PR #1337, you could re-use it here. The code block 3637-3650 is the same as the o

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

2016-01-13 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1338 CLOUDSTACK-9236: Load Balancing Health Check button displayed when non-NetScaler offering is used Load balancing health check option / button should only be displayed when a NetScaler b