[GitHub] cloudstack pull request: CLOUDSTACK-9235: Autoscale button is miss...

2016-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9235: Autoscale button is miss...

2016-01-18 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1337#issuecomment-172691481 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack pull request: CLOUDSTACK-9235: Autoscale button is miss...

2016-01-18 Thread pdube
Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1337#discussion_r50060205 --- Diff: ui/scripts/network.js --- @@ -3667,8 +3652,16 @@ return 2; //hide Autoscale butt

[GitHub] cloudstack pull request: CLOUDSTACK-9235: Autoscale button is miss...

2016-01-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1337#issuecomment-171373038 Hi @nitin-maharana, What about a little change in your code? The complexity of that if/else structure that you are working on is too big.

[GitHub] cloudstack pull request: CLOUDSTACK-9235: Autoscale button is miss...

2016-01-13 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1337 CLOUDSTACK-9235: Autoscale button is missing in VPC Autoscale button is missing. This should not be the case since we are able to add NS as the external LB provider in VPC. Step