Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1335
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1335#issuecomment-172369877
LGTM, makes sense. Checked syntax and that is also still OK.
https://cloud.githubusercontent.com/assets/1630096/12379391/223bdafa-bd5a-11e5-9795-1252ed58
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1335#issuecomment-171279858
LGTM, this return statement is immediately following another return
statement and is thus unreachable.
---
If your project is set up for it, you can reply to
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1335#discussion_r49585171
--- Diff: ui/scripts/cloudStack.js ---
@@ -213,8 +213,6 @@
domainid: g_domainid
}
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1335
CLOUDSTACK-9230: Remove unnecessary return statement from cloudStack.js
Removed the unnecessary return statement.
The statement is never reached.
You can merge this pull request into
