[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

2016-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1327 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

2016-01-11 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1327#issuecomment-170505131 It's sorted! LGTM ![screen shot 2016-01-11 at 11 45 06](https://cloud.githubusercontent.com/assets/5996146/12231567/d518d86e-b858-11e5-979e-fbdb3035a3f6.

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

2016-01-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1327#issuecomment-170454175 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

2016-01-10 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1327#issuecomment-170453979 @remibergsma: Checked for all alphabet names, its sorting perfectly. But how it is sorting for special character names starting with @, #, etc. Is it sorting

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1327#issuecomment-170359075 code reviewed, simple fix for convenience in large installations: LGTM --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

2016-01-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1327#issuecomment-170333254 @nitin-maharana Could you please review this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

2016-01-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1327#issuecomment-170276128 Before this PR it was unsorted: ![cloudstack_pr1327_2](https://cloud.githubusercontent.com/assets/1630096/12218094/628f46dc-b715-11e5-8933-25b26c827b8f.png)

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

2016-01-09 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1327 CLOUDSTACK-9220 Sort list of domains on Domain tab in UI The list of domains was unsorted and that annoyed me so I sorted it :-) You can merge this pull request into a Git repository by run