Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-201959648
### ACS CI BVT Run
**Sumarry:**
Build Number 133
Hypervisor xenserver
NetworkType Advanced
Passed=104
Failed=1
Skipped=4
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-188129352
Thanks @nvazquez @rafaelweingartner - I could not reply in time, but LGTM
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-187969486
Merged based on integration tests that were executed and code reviews; hope
I did not do any mistake (my first merge for ACS).
---
If your project is set
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1310
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-186444960
Hi @bhaisaab sorry I couldn't post this earlier but I've been working on
another pull request and couldn't be able to test this one before.
As my chages af
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-180368839
@nvazquez Yes, please run all the smoke tests against real hardware, the
tests are in test/integration/smoke. You can run them one by one or multiple.
The idea is
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-180363651
Hi @bhaisaab can you help me testing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-176351414
Hi @bhaisaab ,
Which test files would you like me to run? Is this ok with this command on
each file?
nosetests --with-marvin --marvin-config=setup/dev/
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-175689785
LGTM, can we have regression test results against VMware then we would be
able to merge this.
---
If your project is set up for it, you can reply to this email an
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-173439752
Thanks for your help @cristofolini!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-173364669
Thanks again, @nvazquez. The unit test you wrote is a nice improvement and
I'm fine with it. :)
Code LGTM.
---
If your project is set up for it, you can r
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-173350754
Thanks @cristofolini
I've tryied writing a marvin test for testing this feature which would be:
* Select (or create) a vm (id=) which is already running
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-171798749
Thanks for taking the time to add the descriptions and refactoring,
@nvazquez. It has helped readability quite a bit. :)
Now, in case you're interested
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-171752709
Hi @cristofolini
Thanks for your comments. I refactored the method to make it more readable
into two methods, and added description to both, like javadoc.
--
Github user cristofolini commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1310#discussion_r49279282
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1895,6 +1896,9 @@ protected StartAnswer e
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1310
CLOUDSTACK-9211: Support passing vRAM size to support 3D GPU on Vmware
JIRA TICKET:
https://issues.apache.org/jira/browse/CLOUDSTACK-9211
CS support passing hypervisor options by
16 matches
Mail list logo
