Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-172261610
I agree we need to fix some issues like this , which is difficult to be
reproduced but it is obviously an issue from code view.
---
If your project is set up f
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-172259457
@remibergsma We have this one running in production right now and it is
working as expected.
I spent some time in trying to get a test-case up and running, but
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169320044
@remibergsma Can we merge this one? It fixes a bug.
To clarify, this is how the method has been defined:
def default_network_rules(vm_name, vm_id, vm_i
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169267155
LGTM, just code review. simple but really make sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169134133
@DaanHoogland No idea. Might work with Xen if we manage those Instances
through libvirt. But in case of KVM we can probably do this with libvirt. Might
need to patches
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169133424
@wido will your proposal from CLOUDSTACK-1164 work for other hypervisors as
well?
---
If your project is set up for it, you can reply to this email and have y
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169117271
@DaanHoogland I agree, this script isn't the best in the world.
In my opinion we should offload this work to libvirt:
- http://libvirt.org/formatnwfilter.ht
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169095187
@wido My point exactly. 10 lines up a conditional should guard the split()
call
---
If your project is set up for it, you can reply to this email and have you
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169095290
btw LGTM if you don't want to improve further.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169069686
Forgot to add, pylint still works fine. It scores 3.54/10. Not great, but a
lint check still succeeds.
---
If your project is set up for it, you can reply to this ema
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169067941
@DaanHoogland We do not have any unit testing in place for Python. If you
look just 10 lines up you see the method being called exactly that way.
Without this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169066689
simple fix but a test on the contents in the called method makes sense as
well. Not sure how to test.
---
If your project is set up for it, you can reply to t
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169063660
@DaanHoogland @remibergsma @resmo Could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/1309
CLOUDSTACK-9210: Pass secondary IPs to default_network_rules() function
This is a mandatory argument but it was NOT passed which caused the
re-programming of security groups to fail.
S
15 matches
Mail list logo
