Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1272
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1272#issuecomment-173205246
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1272#issuecomment-172421544
@DaanHoogland Thanks for reviewing the code. On MS shutdown/restart the
incomplete job entry will always get marked as cancelled in DB.
You are right that an
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1272#issuecomment-172323097
@koushik-das your change makes perfect sense to me from a db housekeeping
point of view. I have one (little) doubt; what are the semantic ramifications.
An asy
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1272#issuecomment-172318575
Ping @DaanHoogland @borisroman @wilderrodrigues Can you guys have a look at
this one-line change please? Thanks!
---
If your project is set up for it, you can
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1272#issuecomment-166552880
Steps to test:
- Prior to fix check for jobs in async_job table where job_status = 2 and
job_complete_msid is NULL.
- These entries won't get cleane
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/1272
CLOUDSTACK-9195: Cancelled/failed async jobs not getting cleaned up fâ¦
â¦rom DB
Setting 'job_complete_msid' field in async_job table when marking job as
cancelled during MS rest
