Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1300#issuecomment-171666469
Code changes LGTM, looked in the UpdateVpnGatewayCmd and checked the
response name (it is 'updatevpngatewayresponse').
---
If your project is set up for it, you can
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1300#issuecomment-170801305
@kishankavala @koushik-das : Can you please review this. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1300#issuecomment-170279494
LGTM
Didn't work before:
.
---
If your project is set up for it, you can reply to this email
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/1264
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1300#issuecomment-168289311
Reference #1264 (The PR against master).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1300
CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing
Reproducible Steps:
1.Create a customer gateway for a VPC.
2.Edit it using UI(API call is UpdateVpnCustom
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1264#issuecomment-168282637
Sure @remibergsma. I will a PR against 4.7. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1264#issuecomment-168244857
@nitin-maharana Thanks for the fix! I'd suggest making this PR against 4.7
(it will end up on master as well).
---
If your project is set up for it, you can re
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1264#issuecomment-168148620
LGTM.
This is same to the fix in our internal branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1264#issuecomment-168115603
cc @kishankavala @bhaisaab @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1264#issuecomment-166258585
Hi @ustcweizhou, The error function is not necessary but it is good to
write this in call. Here the request doesn't fail but throws an error. Thanks
for the
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1264#issuecomment-166223301
@nitin-maharana
I am not sure if it is necessary to add the following change after success,
but I added it in my fix, basides your change.
```
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1264#issuecomment-166223258
cc @JayapalUradi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1264
CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing
Reproducible Steps:
1.Create a customer gateway for a VPC.
2.Edit it using UI(API call is UpdateVpnCustom
16 matches
Mail list logo
