[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2016-01-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1301 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2016-01-16 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1301#issuecomment-172181790 @nitin-maharana Love you PR details, dude! That's how a PR should be created. :) Ping @remibergsma LGTM, please proceed with merg

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2016-01-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1301#issuecomment-170360230 @DaanHoogland What a waste of resources :-( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1301#issuecomment-170358366 @remibergsma again I see things we have internally at Leaseweb as well. @ustcweizhou can you have a look as well? --- If your project is set up for it, you ca

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2016-01-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1301#issuecomment-170225276 @nitin-maharana The title of the PR is a bit confusing though. Admin can see VPC, just not all the details. But anyway, let's get another review and merge it. P

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2016-01-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1301#issuecomment-170225209 LGTM Before this PR, the nr of ip adresses was shown correctly: https://cloud.githubusercontent.com/assets/1630096/12215672/4b4c9716-b6c7-11e5-8

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-31 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-168290892 Closing this PR as made a new PR #1301 (Against 4.7 which will be merged in master later). --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-31 Thread nitin-maharana
Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/1258 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-31 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1301#issuecomment-168290875 Reference PR #1258 (Against master). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-31 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1301 CLOUDSTACK-9186: Root admin cannot see VPC created by Domain admin user Issue: = Root admin cannot see LB rules and Public LB IP addresses created by domain-admin in UI there

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-31 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-168245371 @nitin-maharana This fix should be against 4.7 IMHO. Can you make a PR for that please? We can still refer to the reviews that have been done. This way both 4.7

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-30 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-168115394 cc @kishankavala --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-28 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-167539882 @nitin-maharana thanks for checking. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-27 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-167485441 @rafaelweingartner : The recursive parameter is not necessary here, because we don't provide the domain id parameter. --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-27 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-167484956 @remibergsma : I didn't check in other API calls. If i come across any, then will raise the issue. Thanks. --- If your project is set up for it, you can rep

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-20 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-166114305 @nitin-maharana shouldn't we use the "recursive" parameter set to "true" too? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-20 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-166112617 @nitin-maharana Thanks. Are there any other api calls that have the same issue? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-20 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-166109722 cc @remibergsma @kishankavala --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-17 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1258 CLOUDSTACK-9186: Root admin cannot see VPC created by Domain admin user Issue: = Root admin cannot see LB rules and Public LB IP addresses created by domain-admin in UI there