[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1271 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-04-25 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-214406895 Great thanks... :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-04-24 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-214154019 @swill done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-213421066 Ok, perfect. Thanks @footplus for confirming. :) @anshul1886, I just need this PR to be force pushed to kick off jenkins again to get everything green so we

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-04-22 Thread footplus
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-213389763 @swill this is completely a LGTM :) We have this working on CS 4.8 in production. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-04-21 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-212987286 @footplus Is that a LGTM? I need one more LGTM code review. @anshul1886, can you please force push to the PR again to kick of jenkins so we can get that to a

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-04-21 Thread rajesh-battala
Github user rajesh-battala commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-212780472 Looks good to me. After this patch on pressing "/" on console not showing/activating the search bar. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-03-29 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-202837715 ### ACS CI BVT Run **Sumarry:** Build Number 143 Hypervisor xenserver NetworkType Advanced Passed=101 Failed=3 Skipped=4

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-03-02 Thread footplus
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-191264802 Hello, I was able to confirm this patch works on CloudStack 4.8.0. The only thing is to take care of removing the systemvm-4.8.0.iso from the secondary storage, an

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-01-30 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-177167744 The problem is clear: ![screen shot 2016-01-30 at 13 35 41](https://cloud.githubusercontent.com/assets/1630096/12695748/f207e5ce-c757-11e5-9097-d9b41b75d26f.

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-01-24 Thread rodrigo93
Github user rodrigo93 commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-174322677 I tested it in my Firefox and it does exactly as @anshul1886 says. Instead of sending the command to the VM, firefox opens the search tool. Can anybody test th

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2015-12-21 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1271 CLOUDSTACK-9164: Prevent firefox's quick search from opening in VM console https://issues.apache.org/jira/browse/CLOUDSTACK-9164 You can merge this pull request into a Git repository by runn