[GitHub] cloudstack pull request: CLOUDSTACK-9162: Unable to add VPN user v...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1241#issuecomment-219137690 @kansal can you close and reopen for do a force push to try to get Jenkins green. I am not sure what to do about this PR because I don't know that I have a way to ve

[GitHub] cloudstack pull request: CLOUDSTACK-9162: Unable to add VPN user v...

2016-05-12 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1241#issuecomment-218959511 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cloudstack pull request: CLOUDSTACK-9162: Unable to add VPN user v...

2016-05-12 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1241#issuecomment-218959533 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] cloudstack pull request: CLOUDSTACK-9162: Unable to add VPN user v...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1241#issuecomment-216208430 LGTM tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-9162: Unable to add VPN user v...

2016-04-21 Thread kansal
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/1241#issuecomment-212807918 @jayapalu rebased. Please have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: CLOUDSTACK-9162: Unable to add VPN user v...

2016-04-20 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/1241#issuecomment-212754454 @kansal Can you please rebase it with the master once. Code changes are fine, I will test once rebased branch. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9162: Unable to add VPN user v...

2015-12-14 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1241#issuecomment-164402122 @kansal I think this is a good fix but can't be sure. A typical case where an integration test showing the behaviour would help greatly. I'm sure marvin can si

[GitHub] cloudstack pull request: CLOUDSTACK-9162: Unable to add VPN user v...

2015-12-13 Thread kansal
GitHub user kansal opened a pull request: https://github.com/apache/cloudstack/pull/1241 CLOUDSTACK-9162: Unable to add VPN user via API with Required Paramet… …ers - Fixed RCA: When we do not provide account parameter which is an optional field , API picks up the a