Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-164288018
For the sake of it, I run a some generic integration tests and they are
happy.
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-164277430
@DaanHoogland thanks Daan, I'll look into the failing issues with Abhi
tomorrow.
---
If your project is set up for it, you can reply to this email and have your
r
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-164277189
@remibergsma @bhaisaab @agneya2001 confirmed that the problem with the last
two tests is in master as well. I am satisfied nothing breaks in the quota
plugin,
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-164271487
I will try a run without this PR to confirm it is not a problem with the
code
---
If your project is set up for it, you can reply to this email and have your
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-164271142
@DaanHoogland thanks, I think you're right but only @agneya2001 can confirm
this.
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-164270791
I think the problem is in the tests as it starts with an empty balance. Can
you confirm @bhaisaab , @agneya2001 ?
---
If your project is set up for it, you ca
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-164269573
thanks @bhaisaab I forgot setting indeed, 5 out of 7 tests now succeed.
investigating the other two now
---
If your project is set up for it, you can reply t
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-164268405
LGTM
@DaanHoogland to use the plugin and run tests, your zone cfg need to enable
the quota plugin global setting and restart mgmt server before the plugin/apis
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-164266288
@agneya2001 I ran test_quota.py
```
nosetests --with-marvin
--marvin-config=/data/shared/marvin/mct-zone1-kvm1-kvm2-zwps.cfg -s -a
tags=advanced,requ
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-16428
Ping @bhaisaab any chance to get this reviewed today? ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1234#discussion_r47443410
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -383,31 +383,41 @@ public QuotaTariffV
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-164248806
Kept it as a major bug as the account with negative quota will still get
locked if quota is enforced, by the quota service thread, when it runs next.
Whi
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1234#discussion_r47443258
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -95,7 +95,7 @@
@Inject
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1234#discussion_r47443252
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -383,31 +383,41 @@ public QuotaTariffVO
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-164246827
@agneya2001 is this 'only' a major bug? it seems to me to be the purpose of
the quota system. blocker may be overdone but I really like this in before 4.7
as r
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1234#discussion_r47442757
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -95,7 +95,7 @@
@Inject
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1234#discussion_r47442747
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -383,31 +383,41 @@ public QuotaTariffV
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-164244364
Thanks abhi, I will run it after the regular suite passes and add it to my
fork of it, and of course report here.
---
If your project is set up for it, you ca
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-164243999
@DaanHoogland This does have a smoke test here:
test/integration/smoke/test_quota.py. This is very basic, will add more test
scenarios to it.
---
If your pro
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-164243359
@agneya2001 looks good, I don't understand all of it yet, partly because
this is rather new functionality. Any plans on integration tests?
I'll add som
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1234
CLOUDSTACK-9153: When negative credits are added to an account the
When negative credits are added to an account the balance credits can
become negative for that account. This will fix will
22 matches
Mail list logo
