[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-13 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164253054 Thanks @DaanHoogland @remibergsma @bhaisaab and @borisroman for reacting very quickly! --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164200657 LGTM :+1: **Environment** - 2 KVM host on CentOS 7.1 - 1 Management Server on CentOS 7.1 - Agent + Common RPMs built from source

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164186662 Update: this resolved our production problem. It now works fine in master+this PR. LGTM :+1: --- If your project is set up for it, you can reply to t

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164177507 Update: Verified the same as above in our pre-production environment (aka Employee Cloud). Will now deploy to production as it works as expected. When the integ

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164176585 @DaanHoogland Thanks. Deploying to a real cloud as we speak. Will verify there too. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164176274 As an operator I want this in :p have only read the feature description in jira and the diff but lgtm based on that and @remibergsma his test results. --- If

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164172595 First test results: keepalived.conf looks as expected: ``` vrrp_instance inside_network { state EQUAL interface eth2 virt

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164171363 Jenkins error unrelated to PR change: ``` Build timed out (after 120 minutes). Marking the build as aborted. ``` --- If your project is set up for i

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164170412 @bhaisaab nice suggestion! Not sure if it is needed though. The vrrp is done over the first guest network, so it cannot clash with other router pairs. Other tie

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164167571 LGTM, perhaps we can use VPCID % 255 to get a value that is less than 255 but greater than 0? @remibergsma @fborn @wilderrodrigues Do you think using a static/f

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164163749 You can read the following from man keepalived.conf: ``` # arbitary unique number 0..255 # used to differentiate multiple instances of vrrpd

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164163586 Thanks for the quick fix @wilderrodrigues. Bit explanation: redundant routers worked fine in our 4.7 cloud, then all of a sudden were broken. Root caus

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164161230 Ping @remibergsma @DaanHoogland @borisroman Could you guys test it before the RC? I just fixed, but have to go to a concert now. --- If your proj

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1231 CLOUDSTACK-9151 - As a Developer I want the VRID to be set within the limits of KeepaliveD This PR fixes a blocker issue! - Just like with RVRs, use the VRID 51 instead of