Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-173185348
Conflicts, won't resolve them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-165057616
@wilderrodrigues ok, I see how you meant 'should' now, please convince
Rohit, not me. I you want to convince me you have to argue why we should keep
maven n fa
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164783572
@DaanHoogland, there was no strong argument about it. @bhaisaab doesn't as
point that can stop a merge. He simply wants to make his daily tasks easier -
pro
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164402621
@wilderrodrigues nice rant and I agree with most except for the part where
it should have been merged. There were objections so this is a clear example of
a th
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164371097
@DaanHoogland @bhaisaab
The first thing is that using a standard is better than doing the way
nobody else is doing. When one adopts a technology is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164272024
@bhaisaab me too, and I am willing to put it on a long track but let's
investigate and discuss more
---
If your project is set up for it, you can reply to thi
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164271638
@DaanHoogland I'm not opposed to the change it is just that I think it
makes my life challenging with some of the things I do on day-to-day basis :)
We do follow a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164271374
@bhaisaab I don't like maven but we are using it! cherry-picking is really
not an argument and backporting is difficult for worse reasons then this one.
Usi
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164270707
@DaanHoogland @borisroman - I sincerely don't grok the benefits of these
changes, which is why I'm asking what are the benefits of the changes?
Some potent
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164204798
LGTM, and I agree with @borisroman the incremental change is better as we
had some initial problems with utils, After NSX and KVM I think we can
accelerate. un
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164174058
LGTM based on these tests (run on KVM):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
co
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164171043
@borisroman what benefits we will have?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169626
@bhaisaab I think an incremental approach is better. I will also create
issue for all other projects and move the each at a time. The
plugin-hypervisor-kvm just
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169497
@miguelaferreira I also think incremental is better. Keeps changed
contained and documented. Else it would be a PR that changes "OVER "
files...
---
If yo
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169391
And btw LGTM! Nice one @borisroman
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169348
Since no one is making a PR to improve all modules, I would say that
incremental improvement is better than no improvement at all. I have done the
same to t
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164167703
This is codebase wide issue that we're not following the default maven
directory structure for all the maven projects/modules. What is the motivation
behind doing
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164163315
It works! Though please tests yourself for more confidence!
**Environment**
- 1 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164157579
Nice one, @borisroman !
LGTM :+1:
Waiting for the test results. :)
---
If your project is set up for it, you can reply to this email and
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1224
CLOUDSTACK-9146: Refactor Hypervisor KVM into default Maven directory
structure.
Ping @wilderrodrigues @wido @remibergsma @miguelaferreira
Refactored the `Apache CloudStack Plugin
21 matches
Mail list logo
