[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...

2015-12-14 Thread wido
Github user wido closed the pull request at: https://github.com/apache/cloudstack/pull/1220 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...

2015-12-14 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1220#issuecomment-164673949 Closing this one for now since it doesn't work on Java 7. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...

2015-12-12 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1220#issuecomment-164168237 @bhaisaab Good idea to do that indeed. I think many of us want Java 8. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...

2015-12-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1220#issuecomment-164167812 Time to move to Java 8, post 4.7 perhaps? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...

2015-12-12 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1220#issuecomment-164134556 @remibergsma Hmm, that's weird. It compiled on my desktop. This seems like a Java version thingy. --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...

2015-12-11 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1220#issuecomment-164021612 @wido please have a look: ``` [ERROR] COMPILATION ERROR : [INFO] - [ERROR] /hom

[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...

2015-12-11 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1220 CLOUDSTACK-9141: Validate userdata for valid base64 This prevents the userdata from going through the stack completely and finding out very late in the process that it is invalid data. You can