Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1221
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1221#issuecomment-164137434
LGTM based on running the tests:
```
[root@cs1 integration]# cat
/tmp//MarvinLogs/test_internal_lb_SFTBEY/results.txt
Test create, assign, remo
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1221#issuecomment-164135820
Thanks for the reviw, @borisroman! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1221#discussion_r47429990
--- Diff: test/integration/smoke/test_internal_lb.py ---
@@ -286,9 +302,12 @@ def setUpClass(cls):
%s" % (cls.account.name
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1221#discussion_r47416109
--- Diff: test/integration/smoke/test_internal_lb.py ---
@@ -286,9 +302,12 @@ def setUpClass(cls):
%s" % (cls.account.name,
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1221#issuecomment-164071815
Hi @wilderrodrigues ,
Looks good! Thanks for making the tests compliant!
```
Test create, assign, remove of an Internal LB with roundrobin ht
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1221#issuecomment-164001738
Ping @remibergsma @DaanHoogland @borisroman @michaelandersen @bhaisaab
@karuturi @miguelaferreira
Please, keep in mind that this PR depends on PR #
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1221
CLOUDSTACK-9135 - As a Developer I want the test_internal_lb.py to test
Redundant VPCs
This PR refactors the existing tests and adds tests to cover internal LB
with Redundant VPCs.
