Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1209
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1209#issuecomment-164279515
LGTM :+1:
Based on code-review and @remibergsma tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1209#discussion_r47437641
--- Diff: engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java ---
@@ -222,11 +222,20 @@ public String getIpAddress(long networkId, long
instanceId) {
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1209#discussion_r47435854
--- Diff: engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java ---
@@ -222,11 +222,20 @@ public String getIpAddress(long networkId, long
instanceId) {
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1209#issuecomment-164174368
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1209
CLOUDSTACK-9134: set device_id as the first device_id not in use instead of
nic count
when we restart vpc tiers, the old nics will be removed, and create a new
nic.
however, the d
